Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F.simple hashmap type #369

Merged
merged 3 commits into from Dec 7, 2020

Conversation

floriankramer
Copy link
Member

This pr turns the ad_utility::HashMap type into a typedef to avoid having to declare all required funtions of the hash map manually using a using statement.

It also replaces ad_utility::HashSet with a typedef of absl::flat_hash_set, switching away from google::dense_hash_set. I assume the same arguments for switching from googles dense_hash_map to abseil apply for hash sets, but in case they don't this change is it's own commit that can be easily removed from this pr.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think this heavily reduces confusion.

@joka921 joka921 merged commit 72e084f into ad-freiburg:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants