Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr turns the
ad_utility::HashMap
type into a typedef to avoid having to declare all required funtions of the hash map manually using ausing
statement.It also replaces
ad_utility::HashSet
with a typedef ofabsl::flat_hash_set
, switching away fromgoogle::dense_hash_set
. I assume the same arguments for switching from googlesdense_hash_map
to abseil apply for hash sets, but in case they don't this change is it's own commit that can be easily removed from this pr.