Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundancy in Sort and OrderBY Operation #379

Closed
joka921 opened this issue Apr 19, 2021 · 1 comment
Closed

Redundancy in Sort and OrderBY Operation #379

joka921 opened this issue Apr 19, 2021 · 1 comment
Labels
cleanup Non functional change for better maintainability or portability

Comments

@joka921
Copy link
Member

joka921 commented Apr 19, 2021

We currently have two subclasses of the Operation class which both handle the sorting of an input, called Sort and OrderBy.
One of them is used for an ordering that was specified by the user via an ORDER BY clause in the query, and the other is used for orderings that are automatically inserted for technical reasons (e.g. because some operations require a sorted input).

Since both classes provide the exact same functionality, there is a lot of code duplication here and we should get rid of one of them for better maintainability.

@joka921 joka921 added the cleanup Non functional change for better maintainability or portability label Apr 19, 2021
@joka921
Copy link
Member Author

joka921 commented May 19, 2022

This is not up to date anymore as we will need two operations with different Semantics: "Sort" is sorting on internal IDs for joining whereas "ORDER BY" is the sorting according to the actual values of the IDs such that end users get the desired order.

@joka921 joka921 closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non functional change for better maintainability or portability
Projects
None yet
Development

No branches or pull requests

1 participant