Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type-Erased "user data" in GroupBy class violates RAII #380

Closed
joka921 opened this issue Apr 19, 2021 · 1 comment
Closed

Type-Erased "user data" in GroupBy class violates RAII #380

joka921 opened this issue Apr 19, 2021 · 1 comment

Comments

@joka921
Copy link
Member

joka921 commented Apr 19, 2021

In connection with the GROUP_CONCAT aggregate in connection with GROUP_BY operations a type erased variable called _userData occurs, which is accessed in a type-erased way and which is manually allocated and thus has no RAII destructor.
I highly suspect, that this data can be stored in a typesafe way with a proper destructor, such that we can provide leak-free code automatically.
@joka921
Copy link
Member Author

joka921 commented May 18, 2022

The GroupBy has been completely restructure, and this is no longer an issue.

@joka921 joka921 closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joka921