Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should "sort" and "indexScan" be implemented in the appropriate Operations? #381

Open
joka921 opened this issue Apr 19, 2021 · 0 comments
Open

Should "sort" and "indexScan" be implemented in the appropriate Operations? #381

joka921 opened this issue Apr 19, 2021 · 0 comments
Labels
cleanup Non functional change for better maintainability or portability

Comments

@joka921
Copy link
Member

joka921 commented Apr 19, 2021

Currently the actual implementation of Sorting an (intermediate) result is provided by a class called Engine and only used by the Sort operation. Similarly, the functionality of an index Scan resides in the Index class and not the IndexScan class. We should thoroughly check, if there are good reasons for this architecture or whether we can move this functionality to the appropriate Operation subclasses.
@joka921 joka921 added the cleanup Non functional change for better maintainability or portability label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Non functional change for better maintainability or portability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joka921