Better descriptor for transitive path #384
Conversation
The previous descriptor was very cryptic. The reason (probably) was that neither the subject, nor the predicate, not the object, are directly known by TransitivePath, but need to be obtained via a bit of acrobatics. See the code for details.
src/engine/TransitivePath.cpp
Outdated
| auto optional = getIndex().idToOptionalString(_leftValue); | ||
| if (optional) { | ||
| os << optional.value(); | ||
| } else { | ||
| os << "#" << _leftValue; | ||
| } |
There was a problem hiding this comment.
os << getIndex().idToOptionalString(_leftValue).value_or("#" + std::to_string(_leftValue))
https://en.cppreference.com/w/cpp/utility/optional/value_or
(If you want to, you can make two lines from this, I am sorry, I did not directly tell you this possibility:)
| if (scanOperation != nullptr) { | ||
| os << " " << scanOperation->getPredicate() << " "; | ||
| } else { | ||
| os << " <???> "; |
There was a problem hiding this comment.
os << " " << scanOperation ? scanOperation->getPredicate() : "<???>" << " "
(only as a possibility, what you wrote is more explicit).
There was a problem hiding this comment.
I wrote something like that first, but found it harder to read since it spanned two lines and also the ? : has to be put into parantheses. So I would stick with the current version
src/engine/TransitivePath.cpp
Outdated
| if (optional) { | ||
| os << optional.value(); | ||
| } else { | ||
| os << "#" << _rightValue; | ||
| } |
There was a problem hiding this comment.
Made the change for this one and the above and tested it and it works fine.
Implemented suggestion from Johannes to the original PR.
The previous descriptor was very cryptic. The reason (probably) was that
neither the subject, nor the predicate, not the object, are directly
known by TransitivePath, but need to be obtained via a bit of
acrobatics. See the code for details.