Moved the Vocabulary Implementation back into a CPP file. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Trigger less recomputations when changing the Vocabulary Implementation. - Currently there are still a lot of ugly template instantiations, but the Vocabulary implementation will be changed soon anyway.
hannahbast
approved these changes
May 3, 2021
There was a problem hiding this comment.
Looks good and appropriate, thanks!
I presume (and did not check) that the implementations of the various functions did not change, but were just copied.
I also presume that the explicit instantiations are complete (it wouldn't compile otherwise, so the automatic build will prove this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will trigger less expensive recompilations when the implementation changes.