Less RAM usage during Compilation of CTRE tests #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joka921
commented
May 5, 2021
test/TokenTest.cpp
Outdated
| } | ||
|
|
||
| static constexpr auto x = cls(TurtleTokenCtre::PnCharsBaseString); | ||
| // static constexpr auto x = cls(TurtleTokenCtre::PnCharsBaseString); |
There was a problem hiding this comment.
Delete out-commented code.
test/TokenTestCtreHelper.cpp
Outdated
Comment on lines
1
to
3
| // | ||
| // Created by johannes on 04.05.21. | ||
| // |
test/TokenTestCtreHelper.h
Outdated
| static bool matchStringLiteralLongQuoteString(std::string_view s); | ||
| static bool matchStringLiteralLongSingleQuoteString(std::string_view s); | ||
| static bool matchIriref(std::string_view s); | ||
| }; |
joka921
force-pushed
the
f.expensiveTests
branch
from
c8a7a28
to
9eed874
Compare
* This cleans up the software architecture. * Also equivalently refactor some of the TokenizerTests to use less RAM during compilation (The CTRE module is very RAM intensive)
joka921
force-pushed
the
f.expensiveTests
branch
from
9eed874
to
0c74314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TokenTestrequired an insane amount of RAM to compile (4.5 GB), because the CTRE library is very expensive at compile time. This problem is mitigated in this PR by factoring out certain (duplicate) calls to CTRE to a separate compilation unit.