Correct Request Timing for the Server #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time - TODO: split the Server and the processing engine....
No there is only one timer per Request left.
joka921
force-pushed
the
f.CorrectTotalTime
branch
from
03d0db2
to
3c9e928
Compare
joka921
commented
May 8, 2021
src/engine/Server.cpp
Outdated
Comment on lines
369
to
370
| // TODO(schnelle) we really should use a json library | ||
| // such as https://github.com/nlohmann/json |
There was a problem hiding this comment.
We now do, remove this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
Serverclass had only one timer instance. This lead to wrong request times in the result json whenmultiple requests were processed concurrently (this often happens in the autocompletion evaluation).
This PR introduces one timer per request.