Introduce a Strong Type for Sparql Variables #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to work, Next step: Find out about TEXT() and SCORE() and also add it to the variableColumns (great restructuring).
…e type - TODO (before reviewing): - Remove the SCORE(...) variables, simple parse them to ?:qlever-text-score-?t - change some places from SparqlVariable to optional<SparqlVariable> for the empty checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all variables were plain
std::stringswhich made them hard to reason about ("does this store a variable, a variable or iri/literal, or does this store an arbitrary string)and easy to make mistakes.
This PR goes one big step in the direction of fixing this, by introducing a
SparqlVariabletype which cannot be implicitlyconverted to and from String.
The next step would be to introduce more of those types, e.g.a
TripleElement(variable, literal/iri or property path).