Disable TwoColumnJoin #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joka921
force-pushed
the
qlever.disable-two-column-join
branch
from
e4c9b84
to
ec563c0
Compare
The TwoColumnJoin implemenentation works only in certain cases (when one of the inputs has exactly two columns). With this fix the TwoColumnJoin is only chosen by the query planner when it is actually supported. In all other cases the more general MultiColumnJoin is used. Also the TwoColumnJoin and MultiColumnJoin have no implementation for "Dummy Joins" with three variables, but were previously chosen for dummy joins by the query planner. This lead to errors during query processing. This commit moves these errors to the query planning and adapts the corresponding unit tests. (They were useless as they expected a certain form of query plans for queries which cannot by executed by QLever currently).
joka921
force-pushed
the
qlever.disable-two-column-join
branch
from
d3e14ef
to
47dc4dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TwoColumnJoin does not work when both tables have more than two
columns. For now, always use the MultiColumnJoin.
TODO: However, the TwoColumnJoin can be used in some cases. See the TODO
in the code. Do you know how to do this, Johannes?