Changes to make the fast CTRE index builder work for OSM (do not merge) #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Assume that all triples are subject-predicate-object (no , or ; syntac to avoid repeating the subject and/or predicate) and that all triples are on a single line and end with a newline. 2. Make sure that literals of type ^^geo:wktLiteral can get externalized (they were recognized as xsd values so far, which is a bug) 3. Externalize all literals of length > 128 (so far the threshold was 1024). This will externalize all larger geometries, but not POINTs and simple geometries like buildings. 4. Don't run the TurtelParserTest because it has several tests concerning the escaping of , and ; which now fail due to 1.
hannahbast
force-pushed
the
qlever.osm-hack
branch
from
5ec33c8
to
58f66e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not be merged into the master as is because some of it is ad-hoc (items 1 and 4) and some of it is just congifuration (item 3). Here is what it does:
Assume that all triples are subject-predicate-object (no , or ; syntax to avoid repeating the subject and/or predicate) and that all triples are on a single line and end with a newline.
In the current master, all literals with ^^ after the last quote are considered as xsd values, which cannot be externalized. In particular, this prevents the externalization of literals of type ^^geo:wktLiteral . This could be considered a BUG in the current master, which is fixed by a change in this PR.
Externalize all literals of length > 128 (so far the threshold was 1024). This will externalize all larger geometries, but not POINTs and simple geometries like buildings. This should actually be configurable in the
settings.json.Don't run the TurtleParserTest because it has several tests concerning the escaping of , and ; which now fail due to 1.