Implement "contains envelope" FILTER for OSM data (needs update because it uses the old QLever values) #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Test and implement more advanced types (Containers), and also test the feature of finding the serialization position.
TODO: Adapt unit tests, and verify that the MMap based permutations also work. Also TODO: Remove all the assymetric createFromSomebuffer functions.
…th plain char. The simple fix is to remove it - We generally enforce Utf-8 everywhere, so this is fine.
1. Assume that all triples are subject-predicate-object (no , or ; syntac to avoid repeating the subject and/or predicate) and that all triples are on a single line and end with a newline. 2. Make sure that literals of type ^^geo:wktLiteral can get externalized (they were recognized as xsd values so far, which is a bug) 3. Externalize all literals of length > 128 (so far the threshold was 1024). This will externalize all larger geometries, but not POINTs and simple geometries like buildings. 4. Don't run the TurtelParserTest because it has several tests concerning the escaping of , and ; which now fail due to 1.
TODO: also perform the vocabularyMerging on the additionalDatatypes. - Actually create floats.
TODO: Read and access them.
…loat formatting/lax testing.
TODO: Test this on a real index and implement the filtering.
…te, to try and get better query plans.
TODO: Make this work for more complex settings like the cache size, which requires additional actions, and not only a plain singleton.
…produce valid indices.
hannahbast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parses all bounding boxes from the osm:envelope predicate as two points and stores them efficiently in RAM