Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed a lot of redundant code in the SparqlLexer. #432

Merged
merged 7 commits into from Aug 4, 2021
Merged

Removed a lot of redundant code in the SparqlLexer. #432

merged 7 commits into from Aug 4, 2021

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jul 19, 2021

This is also a part of the currently too large Expression-PR.

hannahbast
hannahbast approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review in 1-1 with Johannes

  1. "emplace" -> "add" in lambda
  2. Check if we can handle comment (currently in "else" part) via just another regex

@joka921 joka921 merged commit 2cc44a1 into ad-freiburg:master Aug 4, 2021
@joka921 joka921 deleted the f.refactorLexer branch August 4, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahbast hannahbast hannahbast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joka921 @hannahbast