Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniProt ONLY: change a few not-yet configurable settings #473

Closed
wants to merge 4 commits into from

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Sep 16, 2021

This will make it easier to merge these hacks with other new features, if we keep a clean version of it.

@hannahbast hannahbast changed the title Only the small externalization HACKS for uniprot Change a few not-yet configurable settings for UniProt build Apr 14, 2022
@hannahbast hannahbast changed the title Change a few not-yet configurable settings for UniProt build UniProt only: change a few not-yet configurable settings Apr 14, 2022
hannahbast and others added 3 commits April 20, 2022 01:08
…d-freiburg#655)

So far, the "prefixes-external" specified in the settings.json were only
checked for IRIs. Now they are also checked for literals (except for
literals with an XSD type and for numeric literals). For example, this
makes it easy to externalize all literals that start with "POLYGON(". On
the side, this commit improves the implementation for isXsdValue (now with a
compile-time regex) and adds a test for it (there was none so far).
@hannahbast hannahbast marked this pull request as ready for review April 20, 2022 02:52
@hannahbast hannahbast changed the title UniProt only: change a few not-yet configurable settings UniProt ONLY: change a few not-yet configurable settings Apr 20, 2022
1. Externalize literals longer than 128 bytes (default in the master is
1024 bytes).

2. Externalize objects of the predicates
<http://www.w3.org/1999/02/22-rdf-syntax-ns#value> and
<http://purl.uniprot.org/core/md5Checksum> (hard-coded because this
currently cannot be specified in the settings.json).
@hannahbast
Copy link
Member

Replaced by the much cleaner and smaller PR #712

@hannahbast hannahbast closed this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants