The actual logic for expression evaluation. #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joka921
force-pushed
the
f.ActualExpressionEvaluation
branch
2 times, most recently
from
c617371
to
1ec37f5
Compare
hannahbast
approved these changes
Oct 5, 2021
- Added switch instead of if-else - Rename IsValidGetter -> IsValidValueGetter - Added clone-method for LimitedVector.
…spatchedBinaryExpression. TODO:: enable the rangeCalculation again in the actual evaluation.
joka921
force-pushed
the
f.ActualExpressionEvaluation
branch
from
37390cf
to
b5df8ff
Compare
hannahbast
approved these changes
Oct 26, 2021
hannahbast
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.