Implement co-routine based streams for beast-based HTTP server #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTF
commented
Dec 1, 2021
This reverts commit bd907bb.
joka921
reviewed
Dec 3, 2021
| while (generator.hasNext()) { | ||
| out << generator.next(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this still needed by some legacy APIs, which are not Server.h ?
There was a problem hiding this comment.
The only remaining usage can be found here:
qlever/src/SparqlEngineMain.cpp
Lines 217 to 218 in 8a9465c
joka921
approved these changes
Dec 3, 2021
joka921
approved these changes
Dec 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically implements a custom body type, that uses coroutines to send data to the client instead of accumulating everything inside a giant string.