Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also handle MIN and MAX aggregates correctly for values from the knowledge base. #518

Merged
merged 1 commit into from Dec 4, 2021
Merged

Also handle MIN and MAX aggregates correctly for values from the knowledge base. #518

merged 1 commit into from Dec 4, 2021

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Dec 4, 2021

No description provided.

hannahbast
hannahbast approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@hannahbast hannahbast left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great + tested it for a few queries, thanks!

@hannahbast hannahbast merged commit 0646719 into ad-freiburg:master Dec 4, 2021
@joka921 joka921 deleted the min_max_nonnumeric branch December 10, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahbast hannahbast hannahbast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joka921 @hannahbast