Implement support for JSON, CSV and TSV when using CONSTRUCT queries #536

RobinTF · 2022-01-08T02:43:55Z

Follow-up to #528

RobinTF · 2022-01-08T02:48:50Z

src/parser/RdfEscaping.h

+ * See https://www.iana.org/assignments/media-types/text/tab-separated-values
+ * for more information.
+ */
+std::string escapeForTsv(std::string input);


For anyone wondering, these are the specifications the SPARQL specification is referencing

joka921

Good work, only some small tweaks are still necessary.

src/engine/QueryExecutionTree.cpp

src/engine/QueryExecutionTree.h

src/engine/Server.cpp

src/parser/RdfEscaping.h

joka921

Very nice,
There's only some small stuff concerning names etc. which is yet to be done.

src/engine/QueryExecutionTree.cpp

src/engine/QueryExecutionTree.h

src/engine/Server.cpp

src/parser/data/Types.h

joka921

This now is the very last single comment:)

src/engine/QueryExecutionTree.cpp

RobinTF added 9 commits January 6, 2022 02:16

Extract common functionality to helper function

eb53e91

Implement rudimentary support for different serialization formats

cee1000

co_yield inline

5492d1a

Fix segfault

98791ce

Fix compile error, due to rebase conflicts

ef9c9eb

Implement escape mechanism for csv/tsv

ca66efd

Adjust json output for frontend

40fe309

Use convenience function

7c56cdf

Add link to gcc bug

580c5c9

RobinTF commented Jan 8, 2022

View reviewed changes

Formatting cleanup

e4048ab

joka921 approved these changes Jan 8, 2022

View reviewed changes

RobinTF added 5 commits January 8, 2022 20:20

Prefer template argument instead of char

5ac6f6b

Address smaller PR comments

07c0fc9

Extract Type declaration into dedicated header file

ffeb8d3

Adjust names to be more accurate

f80fba7

Formatting

6397080

joka921 reviewed Jan 10, 2022

View reviewed changes

src/engine/QueryExecutionTree.cpp Outdated Show resolved Hide resolved

src/engine/QueryExecutionTree.h Outdated Show resolved Hide resolved

src/engine/Server.cpp Outdated Show resolved Hide resolved

src/parser/data/Types.h Outdated Show resolved Hide resolved

RobinTF added 3 commits January 10, 2022 12:09

Use scoped enum

d03ecc8

Enhance error message

032010c

Rename namespace Types -> ad_utility::sparql_types

2954c48

joka921 approved these changes Jan 10, 2022

View reviewed changes

src/engine/QueryExecutionTree.cpp Show resolved Hide resolved

Add static_assert for SELECT case

90b6d5b

joka921 approved these changes Jan 10, 2022

View reviewed changes

joka921 merged commit f3c8713 into ad-freiburg:master Jan 10, 2022

RobinTF deleted the implement-format-variety branch January 10, 2022 17:59

RobinTF mentioned this pull request Sep 23, 2022

Quotes not escaped in result for CONSTRUCT queries #799

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement support for JSON, CSV and TSV when using CONSTRUCT queries #536

Implement support for JSON, CSV and TSV when using CONSTRUCT queries #536

RobinTF commented Jan 8, 2022

RobinTF Jan 8, 2022

joka921 left a comment

joka921 left a comment

joka921 left a comment

Implement support for JSON, CSV and TSV when using CONSTRUCT queries #536

Implement support for JSON, CSV and TSV when using CONSTRUCT queries #536

Conversation

RobinTF commented Jan 8, 2022

RobinTF Jan 8, 2022

Choose a reason for hiding this comment

joka921 left a comment

Choose a reason for hiding this comment

joka921 left a comment

Choose a reason for hiding this comment

joka921 left a comment

Choose a reason for hiding this comment