Add a Google + left aligned pointer .clang-format #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in a recent review we should follow a common code style. At the chair we mostly use Google style and left aligned pointers so lets stick with that. I tested reformatting everything but it's a huge change and even breaks the build due to bad header dependencies (which we should fix separately). So the next plan is to reformat all new and significantly changed files as well as fixing the headers. The first step of this is adding a `.clang-format` file for automatic formatting. Since the file is in the project root `clang-format -i foo.cpp` automatically picks it up when executed within the project tree.
Merged
floriankramer
approved these changes
May 6, 2018
There was a problem hiding this comment.
I think adding a .clang-style file and then requiring all future commits to use that file for styling is a good idea.
I would just change the style for all files though. The two errors that currently occur when doing that are a missing using std::string in ParseException.h and the reordering of the headers in QueryExecutionTree.h causing <bits/unordered_set.h> (which is apparently an internal header of the GNU ISO C++ Library?) to be included before <unordered_set>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in a recent review we should follow a common code style. At
the chair we mostly use Google style and left aligned pointers so lets
stick with that. I tested reformatting everything but it's a huge change
and even breaks the build due to bad header dependencies (which we
should fix separately).
So the next plan is to reformat all new and significantly changed files
as well as fixing the headers. The first step of this is adding
a
.clang-formatfile for automatic formatting.Since the file is in the project root
clang-format -i foo.cppautomatically picks it up when executed within the project tree.