Implement tests for construct query parsing #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTF
commented
Jan 13, 2022
| ASSERT_EQ(toStringView(result->first), std::string(BUFFER_SIZE, 'A')); | ||
| ASSERT_TRUE(result->second); | ||
|
|
||
| auto result2 = writer.get(errorCode); | ||
| ASSERT_EQ(errorCode, boost::system::error_code()); | ||
| ASSERT_NE(result, boost::none); | ||
| ASSERT_TRUE(result2 != boost::none); |
There was a problem hiding this comment.
For some unknown reason the ASSERT_NE/EQ makros cannot be used to compare boost::none with boost::optional. It seems like gtest has a problem trying to instantiate a templated function that produces a string representation of those types
There was a problem hiding this comment.
I'll try this out, if this is a bug.
joka921
reviewed
Jan 13, 2022
test/SparqlAntlrParserTest.cpp
Outdated
|
|
||
| EXPECT_THAT(triples[0][0], IsBlankNode("_:g_0")); | ||
| EXPECT_THAT(triples[0][1], IsVariable("?a")); | ||
| EXPECT_THAT(triples[0][2], IsBlankNode("_:g_3")); |
There was a problem hiding this comment.
EXPECT_THAT(triples[0], {Blank(true, "0"), Var("?a"), Blank(true, "3")});
or even
expectTriple(0, {Blank(true, "0"), Var("?a"), Blank(true, "3")});
There was a problem hiding this comment.
and all Blank nodes are generated, so this can be also abstracted away
| ASSERT_EQ(toStringView(result->first), std::string(BUFFER_SIZE, 'A')); | ||
| ASSERT_TRUE(result->second); | ||
|
|
||
| auto result2 = writer.get(errorCode); | ||
| ASSERT_EQ(errorCode, boost::system::error_code()); | ||
| ASSERT_NE(result, boost::none); | ||
| ASSERT_TRUE(result2 != boost::none); |
There was a problem hiding this comment.
I'll try this out, if this is a bug.
RobinTF
force-pushed
the
construct-tests
branch
from
96f2e8e
to
02fc2c1
Compare
RobinTF
force-pushed
the
construct-tests
branch
from
02fc2c1
to
153a863
Compare
joka921
approved these changes
Jan 24, 2022
joka921
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP some design decisions need to be discussed