Binary vocabulary serialization #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently write to a text file in the vocabularyMerger, and later write to a CompactStringVector in the prefixCompression. This will lead to wrongfully escaped newlines and tabs in the vocabulary. TODO: Directly work on CompactStringVectors, and enable them to be lazily loaded from disk when read in a linear fashion.
Required: - Tests for the CompactStringVector - Documentation for the new code. - Maybe progress for the vocabulary reading. - A converter for old Vocabulary files.
hannahbast
reviewed
Jan 18, 2022
TODO: nested types for the serializers. - Serializer tests for different types.
…al class Implemented a (so far untested) converter from old to new vocabulary.
TODO: ADd tests.
hannahbast
approved these changes
Jan 19, 2022
hannahbast
approved these changes
Jan 20, 2022
hannahbast
approved these changes
Jan 20, 2022
hannahbast
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up the reading of the vocabulary on start up.
There are yet several TODOs, and we can possibly add additional
compression.