Remove unused non-compiling function #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something discovered during the development of #540
Basically this function wasn't refactored properly as part of #320 because
_datawasn't updated todata().Because this function was unused and continues to be unused to this day the template was never instantiated and the compilation did never fail.
I talked with @joka921 about this and we came to the conclusion that passing raw pointers to read data of potentially arbitrary length is dangerous and error-prone.
If this function is ever required in the future it should get re-implemented using
std::spanto provide that extra bit of safety, but for now it can just be removed to keep maintenance costs at a minimum