Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CSV/TSV header row #554

Merged
merged 10 commits into from Jan 28, 2022

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Jan 25, 2022

As discussed with @joka921 the current CSV/TSV export doesn't properly print the headers as specified in the standard.
This PR fixes this issue and does some small-scale refactoring to reduce duplicated code

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

There are some small comments.
I am still trying to figure out whether we should leave this waiting for a little bit
(It does not hurt) and try to merge #546 first.

src/engine/QueryExecutionTree.cpp Outdated Show resolved Hide resolved
src/engine/QueryExecutionTree.cpp Show resolved Hide resolved
src/engine/QueryExecutionTree.cpp Outdated Show resolved Hide resolved
src/engine/QueryExecutionTree.cpp Outdated Show resolved Hide resolved
src/engine/QueryExecutionTree.cpp Outdated Show resolved Hide resolved
src/engine/QueryExecutionTree.h Outdated Show resolved Hide resolved
src/engine/QueryExecutionTree.h Outdated Show resolved Hide resolved
@RobinTF
Copy link
Collaborator Author

RobinTF commented Jan 26, 2022

There are some small comments. I am still trying to figure out whether we should leave this waiting for a little bit (It does not hurt) and try to merge #546 first.

I think this decision should entirely depend on the state of #546
If it is close to being merged (matter of one or two days), then waiting might be a good option. However if there's still some development going on (say some refactorings of the class structure), then merging this PR first is the better option in my opinion because the structure needs to change with the arising merge conflicts anyways

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only want two more comments, which concern already existing code and one variable renaming
(the std::views::iota is not required:))

Thank you very much

src/engine/QueryExecutionTree.cpp Outdated Show resolved Hide resolved
src/engine/QueryExecutionTree.cpp Show resolved Hide resolved
src/engine/QueryExecutionTree.cpp Outdated Show resolved Hide resolved
src/engine/QueryExecutionTree.cpp Outdated Show resolved Hide resolved
@joka921 joka921 merged commit 894f785 into ad-freiburg:master Jan 28, 2022
@RobinTF RobinTF deleted the introduce-table-header branch January 28, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants