New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CSV/TSV header row #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much.
There are some small comments.
I am still trying to figure out whether we should leave this waiting for a little bit
(It does not hurt) and try to merge #546 first.
I think this decision should entirely depend on the state of #546 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only want two more comments, which concern already existing code and one variable renaming
(the std::views::iota
is not required:))
Thank you very much
As discussed with @joka921 the current CSV/TSV export doesn't properly print the headers as specified in the standard.
This PR fixes this issue and does some small-scale refactoring to reduce duplicated code