Improve the interface of SortKey
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joka921
commented
Jan 26, 2022
joka921
commented
- Add consistent comparison
- Add starts_with function.
* Add consistent comparison * Add starts_with function.
builds pass consistently.
Merged
RobinTF
approved these changes
Jan 26, 2022
| bool starts_with(const SortKey& rhs) { | ||
| return get().starts_with(rhs.get()); | ||
| } | ||
|
|
There was a problem hiding this comment.
If get is marked as constexpr, this function can be too if I'm not missing something obvious?
There was a problem hiding this comment.
The obvious thing you are missing is,
that constexpr string is not yet implemented in GCC/clang and then also
the starts_with function of string is not constexpr (which would also be pointless).
I have added a TODO, there is quite some other stuff to do.
But, what you could have said, is that starts_with is const noexcept and
some other functions of this class are also noexcept.
There was a problem hiding this comment.
Of course, I only checked the string_view variant, which is obviously constexpr
and noexcept annotations.
hannahbast
requested changes
Jan 26, 2022
hannahbast
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.