Fix #56: pread() has a smaller size limit than read() on Linux
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pread()` has a size limit around 2.5 GB on Linux see [here](https://stackoverflow.com/questions/36565209/pread-for-very-large-files) While a bit weird on 64 bit systems checking the actually read number of bytes is probably a good idea anyway. While we are here clean up `getLastOffset()` and remove unused (except for its test) `getTrailingOffT()` which did pretty much the same with a copy of the code but returning the read offset directly. This also gets rid of a two more `seek()` (except for getting the file size). More cleanup is likely needed.
floriankramer
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pread()has a size limit around 2.5 GB on Linux seehere
While a bit weird on 64 bit systems checking the actually read number of bytes
is probably a good idea anyway. While we are here clean up
getLastOffset()and remove unused (except for its test)
getTrailingOffT()which did prettymuch the same with a copy of the code but returning the read offset
directly. This also gets rid of a two more
seek()(except for getting thefile size). More cleanup is likely needed.