Implemented several more changes requested during the pull request review #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklas88
reviewed
Jun 27, 2018
src/engine/QueryPlanner.cpp
Outdated
| // Create a group by operation to determine on which columns the input | ||
| // needs to be sorted | ||
| SubtreePlan groupByPlan(_qec); | ||
| std::shared_ptr<Operation> groupBy( |
src/engine/QueryPlanner.cpp
Outdated
| final._qet->resultSortedOn() == sortColumns[0].first)) { | ||
| // Create an order by operation as required by the group by | ||
| std::shared_ptr<Operation> orderBy( | ||
| new OrderBy(_qec, final._qet, sortColumns)); |
|
Looking at builds all day I noticed we still get some compiler warnings in GTests. Somehow I (mis-)remember that this warning was fixed by one of your changes!? Maybe we could fix it in this PR either way. |
…ning. There was a missing 'break' in Filter.cpp that created a implicit fallthrough warning.
Merged
|
On Travis CI I still see one more simple compiler warning that can be fixed by doing |
The pattern trick check ignored the DISTINCT keyword in the alias which leads to false results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the changes requested during the review of the grouping pull request were not yet pushed upstream, as the problem with integers internally being stored as floats was not yet resolved.