Fixes to getLower/UppercaseUtf8() #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On e.g. ARM and POWER char is unsigned (yeah because having it signed wasn't stupid enough they had to make it implementation defined). Thus the check for > 0 for ASCII characters doesn't work, instead check if the most significant bit is set. Also I think the size argument should take the end of the string into account so as to never read past it even for invalid characters.
|
Thanks again, great stuff! Btw, I have been using a style with space between arithmetic operators so far, e.g., |
|
Ah damn, missed a couple. I really should get used to running cpplint... By the way you might have guessed it already but I'll be joining Hannah's group in June and these pull requests are basically the product of me getting familiar with some of the code/projects and work calming down at the old job 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On e.g. ARM and POWER char is unsigned (yeah because having it signed
wasn't stupid enough they had to make it implementation defined). Thus
the > 0 check for ASCII characters doesn't work, instead check if
the most significant bit is set.
I have confirmed both the old and new behavior on my Raspberry Pi.
Also I think the size argument should take the end of the string into
account so as to never read past it even for invalid characters.
On another note I wonder if it might be faster to first take a pass over the string
to determine the final length and then allocate in one go. Then again this would
only matter if this function shows up in profiling.