Don't force "en_US.utf8" locale #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using setlocale(LC_CTYPE, "en_US.utf8") and thus forcing "en_US" we now use setlocale(LC_CTYPE, "") which configures the program to use the default locale's character set instead of forcing the uber-portable "C" or "POSIX" locale. (see "man 3 setlocale"). On a sane system this will use UTF-8, we do not care about insane systems. The main advantage of this change is that it allows to use docker containers without running "locale-gen" in the container thus making the image smaller.
|
|
|
Arghh, there are few things I feel as profound hatred for as for whoever thought it was a good idea to ever internationalize decimal separators. Instead everyone should have just let "." win worldwide and be done with this nonsense. That said, I only did @floriankramer or can you counter confirm that it breaks on your system? |
floriankramer
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
setlocale(LC_CTYPE, "en_US.utf8")and thus forcing "en_US" wenow use
setlocale(LC_CTYPE, "")which configures the program to use the defaultlocale's character set instead of defaulting to the uber-portable "C" or "POSIX"
locales. (see "man 3 setlocale").
On a sane system this will use UTF-8, we do not care about insane systems.
The main advantage of this change is that it allows to use docker containers
without running "locale-gen" in the container thus making the image smaller
(~150 MB instead of ~220 MB using a Ubuntu 18.04 base)