Dockerfile #75
Merged
Dockerfile #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were printing the debug flags and -fsanitize=thread was in the required not debug flags. Sadly putting it in the debug flags breaks Travis, so for now remove it
floriankramer
approved these changes
Jul 26, 2018
This uses docker multi stage builds. While they are a bit more complicated this makes the final image a lot smaller and shows a very clear distinction between build and runtime dependencies (runtime dependencies being basically only libc and libstdc++)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses docker multi stage builds. While they are a bit more complicated this
makes the final image a lot smaller and shows a very clear distinction between
build and runtime dependencies (runtime dependencies being basically only libc
and libstdc++)
This PR also includes small changes to the CMakeLists.txt most importantly
fixing a wrong build message that showed the DEBUG flags even though it said
that they were the RELEASE flags