Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Add order_numeric, and order_string checks #77

Merged
merged 2 commits into from Jul 29, 2018
Merged

E2E: Add order_numeric, and order_string checks #77

merged 2 commits into from Jul 29, 2018

Conversation

niklas88
Copy link
Member

Adds simple checks for numeric and string order. Currently I just take the whole string ignoring the " and "^^xxxx but I think it's okay because all the values in an ordered column should all have the same format. What do you think?

@niklas88 niklas88 mentioned this pull request Jul 26, 2018
@floriankramer
Copy link
Member

As far as I can tell, the comparison should work for most types (including dates).
With xsd:float and xsd:decimal though neither the string nor the numeric method yield the correct order though, as for strings 900 > 1000 ist true and when trying to use the numeric method python can't parse the xsd:float as a float.

@niklas88
Copy link
Member Author

@floriankramer you're right. So if I'm understanding this right, you're proposing that we detect the "xx"^^xsd:float and xsd:decimal and just take the part within the "" for the order_numeric check?

@floriankramer floriankramer merged commit d3da5e5 into ad-freiburg:master Jul 29, 2018
@niklas88 niklas88 deleted the e2e-order-check branch October 31, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants