Fix ad_utlity::strip() crash when the result is empty #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we are here also add a test for similar case in ad_utility::split() though that works and shows the same behaviour as Python's string split()
naetherm
approved these changes
Aug 8, 2018
src/util/StringUtils.h
Outdated
| @@ -568,9 +568,9 @@ inline string rstrip(const string& text, const char* s) { | |||
| inline std::string strip(const std::string& text, char c) { | |||
| auto left = text.begin(); | |||
| auto right = text.end(); // right is of course exclusive | |||
| for (; left != text.end() && *left == c; left++) | |||
| for (; left < text.end() && *left == c; left++) | |||
There was a problem hiding this comment.
One could also use right instead of text.end() here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test triggering the bug mentioned in #86 as well as a minimal fix. For good measure it also adds a test for empty
ad_utility::split()just to make sure we don't have a similar behavior there.There are several other cleanups possible in the
*strip()functions and I've already worked them out. However I think they should go in another PR to keep this one minimal and easy to review.