Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests during docker build #90

Merged
merged 1 commit into from Aug 8, 2018
Merged

Run unit tests during docker build #90

merged 1 commit into from Aug 8, 2018

Conversation

niklas88
Copy link
Member

@niklas88 niklas88 commented Aug 8, 2018

This makes sure that the Docker Cloud auto build doesn't override the :latest Image if unit tests fail. It of course also works locally

@niklas88 niklas88 changed the title Run unit tests on during docker build Run unit tests during docker build Aug 8, 2018
@niklas88 niklas88 requested a review from naetherm August 8, 2018 15:19
Copy link

@naetherm naetherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic ✨

@niklas88 niklas88 merged commit 01f7222 into ad-freiburg:master Aug 8, 2018
@niklas88 niklas88 deleted the dockerfile-improvements branch July 19, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants