Don't use make -j it may exhaust all memory #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was kindly suggested by Marc Lavallée
joka921
approved these changes
Aug 15, 2018
naetherm
reviewed
Aug 20, 2018
| @@ -147,7 +147,7 @@ script. | |||
|
|
|||
| Build the project (Optional: add `-DPERFTOOLS_PROFILER=True/False` and `-DALLOW_SHUTDOWN=True/False`) | |||
|
|
|||
| cmake -DCMAKE_BUILD_TYPE=Release .. && make -j | |||
| cmake -DCMAKE_BUILD_TYPE=Release .. && make -j $(nproc) | |||
There was a problem hiding this comment.
A rule of thumb for a good approximation of -j is usually <NUM CORES> + 1, some also use <NUM CORES> * range(1.5, 2.0).
For <NUM CORES> + 1 and <NUM CORES> * 1.5 the main idea is the following:
You'll have <NUM CORES> for the compilation and and additional thread for management of I/O activity. The latter thread is often in idle mode, so that thread will lead to now problem.
If the hardware supports hyperthreading one can also use <NUM CORES> * 2.0.
But, as usual: Such things highly depend on the underlying hardware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was kindly suggested by Marc Lavallée