Small bugfix in MetaDataConverterMain #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confused one single letter
-- wrong usage of File::read
|
Hmm, I guess this can't fix the broken index? I of course was super optimistic and overwrote the old files for the Clueweb Freebase index |
|
I'm sorry, I think the permutation data was overwritten by basically garbage if you did not keep the backup. It should be enough to rebuild the KB-index since we did not touch anything with the text. The new version of the converter should be fine though. |
|
I think I can just take the KB part from another Freebase based index. So it should be ok. |
niklas88
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
confused one single letter