Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use e.g. clang format for auto formatting #170

Closed
ronag opened this issue Jan 30, 2023 · 3 comments · Fixed by #303
Closed

Use e.g. clang format for auto formatting #170

ronag opened this issue Jan 30, 2023 · 3 comments · Fixed by #303

Comments

@ronag
Copy link
Contributor

ronag commented Jan 30, 2023

Similar to prettier.

@anonrig
Copy link
Member

anonrig commented Feb 3, 2023

I'm +1 on this.

@miguelteixeiraa
Copy link
Contributor

What do you think about adding this as a pre-commit hook?
I just did a PR to https://github.com/ada-url/idna proposing it.
The PR is kinda duty because of the clang-format file changes but you can take a look at how is it here https://github.com/miguelteixeiraa/idna/tree/clang-format-contrib

@miguelteixeiraa
Copy link
Contributor

Also which style base are we going to use? (in that PR I used the Google style base) There is also a clang-format style detector (based on the written code) but since it is a windows-based software I'm not able to try it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants