Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Python 3.8 features #93

Closed
LordAro opened this issue Nov 9, 2021 · 3 comments
Closed

Use of Python 3.8 features #93

LordAro opened this issue Nov 9, 2021 · 3 comments

Comments

@LordAro
Copy link

LordAro commented Nov 9, 2021

Specifically, of typing.Protocol in a couple of places:

class FragmentCallback(Protocol):
def __call__(self, previous_values: Dict[str, Any], slot: int) -> None:
...

class SupportsLessThan(Protocol):
def __lt__(self, other: SupportsLessThan) -> bool:
...

There doesn't seem to be any specifically defined minimum Python version in this repo, but libadalang/langkit/e3-core do specify 3.7, so I guess this would inherit from that?

@pmderodat
Copy link
Member

Hello,

Thank you for pointing this out. Unlike what’s advertised, e3-core currently supports only Python 3.8 and Python 3.9, so e3-testsuite has the same constraint: I’ll add this info to e3-testsuite’s README and to the doc for Libadalang/Langkit’s testsuites (this does not impact the rest of these projects).

@LordAro
Copy link
Author

LordAro commented Nov 9, 2021

I thought that might be the case, thanks for confirming!

@pmderodat
Copy link
Member

You are welcome! The READMEs are now up-to-date, and e3-testsuite’s testing uses Python 3.8 to detect future incompatibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants