Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for disabling of Interrupts #10

Closed
ghost opened this issue Jan 31, 2016 · 6 comments
Closed

Allow for disabling of Interrupts #10

ghost opened this issue Jan 31, 2016 · 6 comments

Comments

@ghost
Copy link

ghost commented Jan 31, 2016

There is only a function to enable interrupts per pin but none to disable interrupts.

Please offer functions to disable interrupt of a single pin or all pins altogether.

@PsuFan
Copy link
Contributor

PsuFan commented Feb 8, 2021

Yes, I agree. Ran into this too... Lost hours because a) MCP wasn't being reset when I was pushing esp8266 reset, b) I wasn't getting the correct interrupt pin and c) this function doesn't exist!

void Adafruit_MCP23017::disableInterruptPin(uint8_t pin) { // disable the pin for interrupt updateRegisterBit(pin, LOW, MCP23017_GPINTENA, MCP23017_GPINTENB); }

@ladyada
Copy link
Member

ladyada commented Feb 8, 2021

hi please submit a PR with the fix!

@PsuFan
Copy link
Contributor

PsuFan commented Feb 8, 2021

Okay, I never submitted a pull before. Hope I did it right, #54

@PsuFan
Copy link
Contributor

PsuFan commented Feb 8, 2021

Wow thanks for the quick integration! Sort of related: How do we feel about disabling all interrupts on begin()?

@ladyada
Copy link
Member

ladyada commented Feb 8, 2021

thats fine

@caternuson
Copy link
Contributor

Closing. Fixed with #54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants