Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

y_offset should not include any impact due to newlines '\n' #78

Closed
kmatch98 opened this issue Aug 4, 2020 · 3 comments
Closed

y_offset should not include any impact due to newlines '\n' #78

kmatch98 opened this issue Aug 4, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kmatch98
Copy link
Contributor

kmatch98 commented Aug 4, 2020

The y_offset is currently incorrectly calculated with the inclusion of a multiple related to the quantity of newlines '\n' in the text string.

However y_offset should be independent of the number of lines in the string, and should just be related to the glyph dimensions, since this acts as a baseline offset to the vertical center of the "M" glyph.

I observed this issue when calibrating text to the upcoming bitmap_label.py file.

@evaherrada
Copy link
Collaborator

@kmatch98 Good find. If you're up for it, a PR would be greatly appreciated.

@evaherrada evaherrada added the bug Something isn't working label Aug 6, 2020
@kmatch98
Copy link
Contributor Author

kmatch98 commented Aug 7, 2020

Thanks @dherrada, please put this into my queue and I will figure it out. Also please note there will be a similar issue to resolve in the parallel library bitmap_label.py.

@kmatch98
Copy link
Contributor Author

Closed with #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants