Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto Focus #31

Open
jerryneedell opened this issue May 3, 2024 · 2 comments
Open

Add Auto Focus #31

jerryneedell opened this issue May 3, 2024 · 2 comments
Assignees

Comments

@jerryneedell
Copy link

I've been working on adding Auto focus support and have it working OK in the jerryn_af branch on my fork
https://github.com/jerryneedell/Adafruit_CircuitPython_OV5640/tree/jerryn_af

I need to add a file to the repository that is used for initializing the auto focus
ov5640_autofocus.bin
ov5640_autofocus.bin.license

but pre-commit fails in the "reuse" check when these files are added to my branch.

black................................................(no files to check)Skipped
reuse....................................................................Failed
- hook id: reuse
- exit code: 1

# MISSING LICENSES

'GPL-2.0-only' found in:
* ov5640_autofocus.bin


# SUMMARY

* Bad licenses:
* Deprecated licenses:
* Licenses without file extension:
* Missing licenses: GPL-2.0-only
* Unused licenses:
* Used licenses: CC-BY-4.0, GPL-2.0-only, MIT, Unlicense
* Read errors: 0
* Files with copyright information: 30 / 30
* Files with license information: 30 / 30

Unfortunately, your project is not compliant with version 3.0 of the REUSE Specification :-(

check yaml...........................................(no files to check)Skipped
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
pylint (library code)................................(no files to check)Skipped
pylint (example code)................................(no files to check)Skipped
pylint (test code)...................................(no files to check)Skipped

these same files are used in the pycamera library
https://github.com/adafruit/Adafruit_CircuitPython_PyCamera/tree/main/adafruit_pycamera

where it is set up as a package.

Do I need to set this up as a package as well for it to pass?
I suppose that will make it cleaner to install.

@jerryneedell jerryneedell self-assigned this May 3, 2024
@jerryneedell
Copy link
Author

Ah -- I fixed the issue with the license.
Still not sure how best to organize this. Would it be better as a "package" so the ov5640_autofocus.bin file is more easily included?

@tannewt
Copy link
Member

tannewt commented May 13, 2024

Ya, I guess that the bundling code expects source files to be in the package folder. I'm not exactly sure how CPython normally does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants