Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status lights don't match documentation #83

Closed
makermelissa opened this issue Nov 16, 2022 · 1 comment · Fixed by #84
Closed

Status lights don't match documentation #83

makermelissa opened this issue Nov 16, 2022 · 1 comment · Fixed by #84

Comments

@makermelissa
Copy link
Contributor

makermelissa commented Nov 16, 2022

According to https://learn.adafruit.com/adafruit-pyportal/pyportal-hardware-faq#faq-3023990, the lights should act as follows:

Red = not connected to WiFi
Blue = connected to WiFi
Yellow = fetching data
Blue = got data
Cyan = file opening

The status colors are changeable at: https://github.com/adafruit/Adafruit_CircuitPython_PortalBase/blob/main/adafruit_portalbase/network.py#L59-L65

I see several issues here:

  1. STATUS_CONNECTED is never used.
  2. It looks like the get_strftime() function in network is not setting the status colors.
  3. It appears the connected color is currently set to green.
  4. It appears the Got Data is blue, though the original comments from the PyPortal library suggest it should have been green (https://github.com/adafruit/Adafruit_CircuitPython_PortalBase/blob/main/adafruit_portalbase/network.py#L281).
  5. The value for STATUS_FETCHING suggests more of an orange color rather than yellow.
@makermelissa
Copy link
Contributor Author

I changed docs to show Green for Got Data as well as code, which I believe was the correct color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant