Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions don't match CPython requests that closely #190

Open
dhalbert opened this issue Apr 26, 2024 · 0 comments
Open

Exceptions don't match CPython requests that closely #190

dhalbert opened this issue Apr 26, 2024 · 0 comments

Comments

@dhalbert
Copy link
Contributor

The CPython requests library has its own set of exceptions: https://requests.readthedocs.io/en/latest/api/#requests.ConnectTimeout
which are subclasses of system exceptions. Here is the source, showing the class definitions:
https://requests.readthedocs.io/en/latest/_modules/requests/exceptions/

I think using some subset of the requests exceptions might be nice for writing compatible code and one with clearer exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant