Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Additional Device Information #335

Closed
elral opened this issue Aug 29, 2019 · 3 comments
Closed

[Feature] Additional Device Information #335

elral opened this issue Aug 29, 2019 · 3 comments
Labels

Comments

@elral
Copy link
Contributor

elral commented Aug 29, 2019

For my project I need to set additional device parameters. To do this I added some methods to BLEDis.cpp and BLEDis.h. It would be great if these additions could be added to the masterbranch. Unfortenutely I do not know how to submit a pull request, therefore I addded my code here.

Thanks and regards

BLEDis.zip

Ralf

@elral elral added the Feature label Aug 29, 2019
@hathach
Copy link
Member

hathach commented Aug 29, 2019

submit a PR is very simple, it is much easier for you and us than attaching zip file. Just create a folk, modify the code then submit PR. Here is the tutorial from github.
https://help.github.com/en/articles/creating-a-pull-request

@elral
Copy link
Contributor Author

elral commented Aug 31, 2019

Thanks, I forked it and changed the files, but "unfortenutely" more than for this Pull Request. It seems that no files can be choosen for a Pull Request, so I have to start again. Will start next week.

@hathach
Copy link
Member

hathach commented Aug 31, 2019

You dont need to choose file, only need to modify, add file to github then commit and push. Then create the pr, github will do the rest for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants