Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to remove max_glyphs restriction from label #131

Closed
FoamyGuy opened this issue Mar 8, 2021 · 2 comments · Fixed by #153
Closed

Try to remove max_glyphs restriction from label #131

FoamyGuy opened this issue Mar 8, 2021 · 2 comments · Fixed by #153
Labels
enhancement New feature or request

Comments

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Mar 8, 2021

Making an issue now so that we keep this in mind. I do think we'll want to hold off on making this change at least until there is a stable release made that includes the changes to Group though so it might be a little bit until we actually need to do anything further.

displayio.Group has been updated to allow it's size to be mutable so more things can be added, and there is no need to use the max_size any longer.

We will be able to change label.Label to make use of this and remove the max_glyphs restriction.

@FoamyGuy FoamyGuy added the enhancement New feature or request label Mar 8, 2021
@tannewt
Copy link
Member

tannewt commented Mar 8, 2021

Let's start moving things off max_size once 6.2.0 has been stable for a little while. We don't want to drop max_size with 6.1.x

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Jul 1, 2021

I'm going to re-open this one for now with the intent to figure out if we can safely remove max_glyphs from label. If it turns out not to be possible we can close this back up.

@FoamyGuy FoamyGuy reopened this Jul 1, 2021
@FoamyGuy FoamyGuy changed the title Update label to use new displayio.Group Try to remove max_glyphs restriction from label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants