Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project dependencies may have API risk issues #37

Closed
PyDeps opened this issue Oct 25, 2022 · 1 comment
Closed

Project dependencies may have API risk issues #37

PyDeps opened this issue Oct 25, 2022 · 1 comment

Comments

@PyDeps
Copy link

PyDeps commented Oct 25, 2022

Hi, In Adafruit_CircuitPython_VL53L0X, inappropriate dependency versioning constraints can cause risks.

Below are the dependencies and version constraints that the project is using

Adafruit-Blinka
adafruit-circuitpython-busdevice

The version constraint == will introduce the risk of dependency conflicts because the scope of dependencies is too strict.
The version constraint No Upper Bound and * will introduce the risk of the missing API Error because the latest version of the dependencies may remove some APIs.

After further analysis, in this project,
The version constraint of dependency Adafruit-Blinka can be changed to >=0.1.5,<=8.0.2.

The above modification suggestions can reduce the dependency conflicts as much as possible,
and introduce the latest version as much as possible without calling Error in the projects.

The invocation of the current project includes all the following methods.

The calling methods from the Adafruit-Blinka
micropython.const
The calling methods from the all methods
self._device.readinto
format
int
self._get_spad_info
self._device.write
_timeout_microseconds_to_mclks
adafruit_vl53l0x.VL53L0X.continuous_mode
float
i.vl53.set_address
time.time
sphinx_rtd_theme.get_html_theme_path
self._write_u16
power_pin.switch_to_output
RuntimeError
print
stop_continuous
self._perform_single_ref_calibration
bytearray
self._write_u8
_encode_timeout
digitalio.DigitalInOut
len
busio.I2C
os.path.abspath
time.sleep
adafruit_vl53l0x.VL53L0X
self._read_u16
board.I2C
_decode_timeout
adafruit_bus_device.i2c_device.I2CDevice
range
self.read_range
str
self._get_sequence_step_timeouts
self._get_vcsel_pulse_period
time.monotonic
i.vl53.start_continous
datetime.datetime.now
self._read_u8
math.pow
detect_range
sensor.stop_continuous
self.do_range_measurement
vl53.insert
micropython.const
_timeout_mclks_to_microseconds
self.stop_continuous
enumerate
self._get_sequence_step_enables
os.environ.get
self.start_continuous
sys.path.insert
ValueError

@developer
Could please help me check this issue?
May I pull a request to fix it?
Thank you very much.

@tekktrik
Copy link
Member

I don't think a change like this makes sense for our project or needs. Thanks for offering though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants