-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIBRARIES page #119
Comments
@jwcooper @tylerdcooper I'd like work together with you to move forward with this as soon as is reasonable. I understand there may be other priorities. |
@kattni I can start on it this week, I hope. For the script component (if possible), I'd like to follow the same process we use for the files.json (https://github.com/adafruit/circuitpython-org/blob/master/_data/files.json) circuitpython release process. For libraries, we could simply add a _data/libraries.json file that is pushed to this repository on each release. Then, we can just pull in that data in jekyll, etc. |
Using the same process as I'll try and get a schema together soon, though it honestly may just come straight out of GitHub's API replies. |
How does the below schema work for you all? Truncated Raw Example:
I can change it up if need be. I have more experience reading JSON than encoding... |
Ha! And in true fashion, now I notice that its using the API URL for library updates. Easy fix. |
The formatting looks great other than maybe dropping the outer array (unless there will be multiple library_updates and open_issues sections)? Should be quite easy to get that displayed with liquid. I'll use that as the test schema, and let you know if I need any other changes. Thanks! |
I don't imagine there will be multiple update/issues section. Will drop the outer array. |
I'm going to get an initial PR for But, as I'm constructing the adabot auto-update-majik part, I have a question. This kind of ties into my lack of knowledge with the plan for automating @kattni, @tannewt: The main difference I see between the two JSON updates is:
|
@kattni, @sommersoft Also, can we add the release bundle download links in the libraries.json? I can pull them from the API, if we need to, but we're already building this json file, so it may make sense to include it (faster page loads as well, if we don't' have to wait for an API request/response in js). Possible updated example file:
|
@jwcooper The contributing section will only contain a small blurb about contributing and a link to a second page. This is intentional - the library report page will be a lot of information and I want it separate from the main page which is meant to be a basic introduction to/download page for CircuitPython libraries. |
@kattni That sounds good. I can move that functionality to /libraries/contributing. We'll probably want the issue titles for that page in the json, since we could re-use that functionality on the contributing, if possible. |
Yeah, that's easy enough. I can add that tonight.
The planned schedule to run the script for |
@sommersoft Sounds good. I'll likely hard link the /latest page as well as build the release bundle zip links from the api with js. |
@sommersoft Here is the latest version of the libraries.json file. The PR is nearly ready to go, just have a couple more things to add in. |
@kattni, @sommersoft Is the repo level issues section automated? If so, I believe we'd need that in the libraries.json file as well. |
@jwcooper Yes, it will need to be there. I was unclear with my expectation so @sommersoft didn't know the entirety of what I wanted for the contributions page. We discussed it last night and he's sorting how he wants to do it since it now resembles the current adabot script more closely. Sommersoft can explain better what his plans are now. |
Sounds good, thank you @kattni! |
Here's a current iteration (i reordered it a little): https://github.com/sommersoft/circuitpython-org/blob/new_lib_json/_data/libraries.json I can push it to your PR if you'd like. Well, once I remember how to do it. 😄 |
@sommersoft At first glance, this looks great. I can copy it over to my fork and integrate the new components that were added. |
@kattni, @sommersoft I think we just need the count for the pull requests merged at this point (based on latest PR review). |
@jwcooper I believe you are correct! There is one more change that needs to be made to the Contributing page, but that's on our end, not yours (change needs to be made to the script). |
Yeah, it'll just be another key. How does |
@sommersoft That works for me. |
@jwcooper We've updated the script with the rest of the necessary information to complete the libraries page. I want to find out, how does the page get updated? Is it triggered by the script updating? Or is there something else to it? I ask because I am considering having the authors/reviewers/newlibs/updatedlibs lists be updated daily as a rolling weekly list. I want to make sure that we're handling that appropriately if we decide to do it - I think it's simply a change on our end for when the script updates, but I don't know that for certain. |
The site rebuilds on any commit to the master branch of this repository. Whenever the script is updated and the PR is merged, it should trigger a re-build. I'll merge in the latest changes to the libraries json. |
@jwcooper Are you okay with the Contributors and New/Updated Libraries lists being updated daily? The Contributing page would be updated weekly. I ask because updating it daily would increase the amount of activity on the repo, and you seem most likely to notice. It won't require any changes on your end, it's something we'd do, but it would mean daily builds. |
I think that's fine as long as it's automated. |
This was completed and merged. |
Here is what I would like to see for the LIBRARIES page.
Main page would be three sections:
Contributing page:
Contributing page linked from the LIBRARIES main page will be information aggregated from all the libraries, updated by a script. It will be text blocks interspersed with lists of links to PRs/Issues/Repos (supplied by the script). The formatting will involve section headings, text and links. I would provide text content.
The script:
The script would supply the assets for the lists on the main page and for building the Contributing page. The script will be written by @sommersoft. It will be designed to update the New/Updated libraries lists, and the Contributing page, on a to-be-determined time interval, likely starting with weekly. We would add a cron job to Travis for circuitpython-org to run the script.
For both the lists on the main page, and the content on the Contributing page, the script can run and update a json file which can be used to populate the pages.
Terrible mock-up included.
The text was updated successfully, but these errors were encountered: