Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove size limit on displayio.Group #2673

Closed
dhalbert opened this issue Mar 1, 2020 · 3 comments
Closed

remove size limit on displayio.Group #2673

dhalbert opened this issue Mar 1, 2020 · 3 comments
Milestone

Comments

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 1, 2020

Group full messages can be confusing. Could we make Group not need a size limit? It could be like a list, or it could resize itself as necessary.

See for example adafruit/Adafruit_CircuitPython_Display_Text#11

@dhalbert dhalbert modified the milestones: Libraries, Long term Mar 1, 2020
@dastels
Copy link

dastels commented Mar 1, 2020

Would this lead to accidentally adding groups (which is what the limit guards against) and getting an even more confusing out of memory error?

@jepler
Copy link
Member

jepler commented Mar 1, 2020

make group.size a settable property, possibly increase-only? that would prevent "accidental" addition of groups, since you have to explicitly ask for the increase. it would address the label use-case for not requiring the size to be specified upfront.

@kmatch98
Copy link
Collaborator

Closed by: #4233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants