Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adafruit_bus_device: SPI object doesn't have spi property (and adafruit_sdcard assumes it) #3859

Closed
jepler opened this issue Dec 22, 2020 · 2 comments

Comments

@jepler
Copy link
Member

jepler commented Dec 22, 2020

Reported by @Neradoc on Discord, this issue is separate from other problems encountered with adafruit_bus_device.

It wasn't immediately clear why adafruit_sdcard uses this property (efficiency?) but as the property was not _spi it was arguably fair game. Possible resolutions that occurred to me:

  • change adafruit_sdcard to not use the property and leave in-core adafruit_bus_device unchanged for the purposes of this PR
  • add the property to adafruit_bus_device and leave adafruit_sdcard unchanged
  • change both even though it's redundant
    I didn't find any uses of adafruit_bus_device.i2c_device.I2C.i2c with my quick grepping in the Learn system code and Bundle, but the same concern may apply there.
@tannewt tannewt added this to the 6.1.0 milestone Dec 22, 2020
@tannewt
Copy link
Member

tannewt commented Dec 29, 2020

This no longer blocks 6.1.0 because we've disabled native bus device for now.

@tannewt tannewt modified the milestones: 6.1.0, 6.x.0 - Features Dec 29, 2020
@dhalbert
Copy link
Collaborator

dhalbert commented Feb 5, 2021

Fixed by #4114.

@dhalbert dhalbert closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants