Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch submodules lazily #8036

Closed
dhalbert opened this issue May 26, 2023 · 2 comments · Fixed by #8070
Closed

Fetch submodules lazily #8036

dhalbert opened this issue May 26, 2023 · 2 comments · Fixed by #8070
Assignees
Milestone

Comments

@dhalbert
Copy link
Collaborator

Instead of having to do a slow make fetch-submodules at the top level after cloning circuitpython, fetch the submodules lazily. Fetch the submodules for a particular port only when a build is done in that port directory.

... working on this.

@dhalbert dhalbert added this to the Long term milestone May 26, 2023
@dhalbert dhalbert self-assigned this May 26, 2023
@bill88t
Copy link

bill88t commented May 27, 2023

I feel like make fetch-submodules shouldn't be removed.
It's nice to be able to run one command to prepare the local repo so that you can go offline.

But seperating it into auto triggers for every port sounds like a great idea.

@joshua-beck-0908
Copy link

joshua-beck-0908 commented Jun 1, 2023

That would be nice. I just wait a long time for every submodule just to change one line of an esp32 board definition. Then the esp-idf build failed anyway. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants