Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up circup requirements; update base Python version; switch to pyproject.toml? #189

Closed
dhalbert opened this issue Nov 10, 2023 · 1 comment · Fixed by #214
Closed

Comments

@dhalbert
Copy link
Contributor

Motivated by #143.

I do not understand the current state of Python package management well enough to decide what to do here, but:

  • ModuleNotFoundError: No module named 'pkg_resources' #143 suggests adding setuptools to circup's requirements; this is because Python 3.12 no longer provides setuptools automatically . If we switched fromsetup.py to pyproject.toml, would this issue go away?
  • circup has an install_requires in setup.py, and also has a requirements.txt. My impression is that the requirements.txt does not actually serve any purpose and could be deleted. Is that right?
  • We are currently supporting Python 3.7 and up. Should we move forward from that? If so, to what version?
@FoamyGuy
Copy link
Contributor

FoamyGuy commented Apr 1, 2024

The requirements.txt file in this repo does seem weird to me. https://github.com/adafruit/circup/blob/main/requirements.txt

There are imports in there that don't seem to actually be required as far as I can tell. Jinja2 caught my eye due to having a dependabot PR open for it. To the best of my knowledge circup doesn't use that, I tried grepping in the repo and the only reference I can find to it is in requirements.txt file.

This file is very long I'm guessing there may be others that aren't actually necessary, this looks like it may be output from someone running pip freeze in a python environment that wasn't a small contained venv for this project only.

I think you are right that it could be removed @dhalbert.

I don't know about the other questions specifically but I do think it would also be nice to switch to pyproject.toml I think for consistency with the majority of libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants