You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I do not understand the current state of Python package management well enough to decide what to do here, but:
ModuleNotFoundError: No module named 'pkg_resources' #143 suggests adding setuptools to circup's requirements; this is because Python 3.12 no longer provides setuptools automatically . If we switched fromsetup.py to pyproject.toml, would this issue go away?
circup has an install_requires in setup.py, and also has a requirements.txt. My impression is that the requirements.txt does not actually serve any purpose and could be deleted. Is that right?
We are currently supporting Python 3.7 and up. Should we move forward from that? If so, to what version?
The text was updated successfully, but these errors were encountered:
There are imports in there that don't seem to actually be required as far as I can tell. Jinja2 caught my eye due to having a dependabot PR open for it. To the best of my knowledge circup doesn't use that, I tried grepping in the repo and the only reference I can find to it is in requirements.txt file.
This file is very long I'm guessing there may be others that aren't actually necessary, this looks like it may be output from someone running pip freeze in a python environment that wasn't a small contained venv for this project only.
I think you are right that it could be removed @dhalbert.
I don't know about the other questions specifically but I do think it would also be nice to switch to pyproject.toml I think for consistency with the majority of libraries.
Motivated by #143.
I do not understand the current state of Python package management well enough to decide what to do here, but:
setuptools
to circup's requirements; this is because Python 3.12 no longer providessetuptools
automatically . If we switched fromsetup.py
topyproject.toml
, would this issue go away?install_requires
insetup.py
, and also has arequirements.txt
. My impression is that therequirements.txt
does not actually serve any purpose and could be deleted. Is that right?The text was updated successfully, but these errors were encountered: