Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make template PyPI status aware #74

Closed
kattni opened this issue Apr 27, 2020 · 2 comments · Fixed by #84
Closed

Make template PyPI status aware #74

kattni opened this issue Apr 27, 2020 · 2 comments · Fixed by #84

Comments

@kattni
Copy link
Contributor

kattni commented Apr 27, 2020

Include a prompt to specify whether a library is destined to be deployed to PyPI. If not, add setup.py.disabled with a specific string in it, instead of setup.py.

I'm not certain how I feel about adding this due to the fact that whether a library ends up on PyPI may not be a decision made by the author, but that's another issue to address.

@2bndy5
Copy link
Contributor

2bndy5 commented Dec 9, 2020

Just a reminder: pip can install straight from git repos as long as there's a setup.py file in the repo root, so deploying to pypi isn't the sole requirement for a valid setup.py existence. requirement.txt files can also specify a dependency from git repos.

python3 -m pip install git+https://github.com/USER_NAME/CircuitPython_LIB_NAME

Additionally, one can append the cmd with @TREE_NAME to install from a specific branch

@kattni
Copy link
Contributor Author

kattni commented Dec 9, 2020

@2bndy5 This is correct! However, if a library is not destined for PyPI, it means there's no reason to be pip installing it in the first place. This would apply to microcontroller-specific libraries, such as Adafruit CircuitPython CircuitPlayground, or libraries that are basically Python modules, such as Adafruit CircuitPython Logging, where you would want to use the Python version anywhere you would be pip installing. So while it's possible to pip install a repo locally, this feature is meant for libraries that wouldn't work in that case. All libraries that can be used on Linux SBCs etc. end up on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants